Receipt Generation

[pmiri]

Users should be able to generate receipts based off of closed batches to be distributed to donors for tax purposes.

-Story Points (13) -Priority (1) -Risk: Medium -Ideal time:

Add "generate receipt" command in API.ai (1 hour)

Navigate and validate closed batch and accept (3 hour)

Navigate donor and accept (3 hour)

Write unit tests (1 hour)

TODO: Link all commits, arch diagrams, summaries of discussions, etc Write your unit tests Write the demo steps Get customer signoff

Demo steps (part 1, pre-feedback)

• log into the web application
• enter "print receipts" or "make receipts" in the chat box
• select Phil Miriello and Brad O as donors
• select Alberta and Phil's Generous Extravaganza as batches
• click "Make Receipts"
• check the output zip file for receipts

Demo Steps (part 2)

• Log into DMSLite as q@q.com
• Type "Print Receipts", select a known donor and a known batch they have donated to, submit
• Type "View donations by name of known donor"
• Click the "Receipt" link present on donations that were receipted by the last print operation

[dsvoid]

The branch Issue53-ReceiptGenetation is using the PdfSharp library over its most likely alternative, iTextSharp. Why?

• PdfSharp has a nice wiki with plenty of examples for quick training.
• iTextSharp is a port of iText for Java and as such the source code isn't as accessible if we run into a problem that requires a peek into the library.
• iTextSharp has some weird licensing deal called AGPL, we'd have to open our codebase if we used it. PdfSharp has no such qualms.

[dsvoid]

Going to /Receipt/Test generates a "Hello World!" PDF. Loath as I am to admit it, this was made possible thanks to this StackOverflow answer.

[dsvoid]

Data can be fetched, but now some more requirements need to be extracted for receipts. I have some assumptions about the process of making receipts that I need checked:

• The user chooses the date range for the receipts donors receive
• The user chooses the specific batches and donors for receipts, and has all of them chosen by default.

Also, a few questions:

• What additional data is missing? (The screenshot shown is for a donor with no address: normally there is one.)
• What does the formatting of an actual receipt look like? Is it possible to see one, so as to find out what kind of formatting is appropriate and what other data is missing?
• Should receipts be separate PDFs per donor, or one PDF?

Feel free to contribute anything else on your mind.

[Bradleyo]

http://www.cra-arc.gc.ca/chrts-gvng/chrts/pbs/rcpts-eng.html

http://www.cra-arc.gc.ca/chrts-gvng/chrts/prtng/rcpts/whtnf-eng.html

[dsvoid]

The ReceiptForm method takes in a ReceiptFormModel object (a list of donors and batches), then outputs a zip file containing individual PDF receipts per donor. Each PDF receipt contains the donations for those batches that the donor made. A donor who made no donations to any of the selected batches gets no receipt as output.

There is no UI for the feature yet, but its behaviour can be manually tested on branch Issue53-ReceiptGeneration Receipt/ReceiptForm URL after building. Right now, it's set to return receipts from all donors for all closed batches.

[dsvoid]

A basic modal was set up using a multiple-selection select2 box. Submission and validation only boils down to not letting the user select "Make Receipts" for now. What remains is making an API.ai call to make receipts, adding proper validation checks for the form, writing tests for receipt generation, and finally removing my cutesy "test receipt generation!" button.

[dsvoid]

Tests pass. Of course the UI could use further work (like date range selection), but until then, have some

Demo Steps

• log into the web application
• enter "print receipts" or "make receipts" in the chat box
• select Phil Miriello and Brad O as donors
• select Alberta and Phil's Generous Extravaganza as batches
• click "Make Receipts"
• check the output zip file for receipts

[Bradleyo]

Some changes to the process here. -1 Each specific donation line should only be receiptable once, and should have the receipt associated to that donation record for cross reference purposes. -2 Some options to add a. receipt for a specific donor or a batch for all donors b. All non-receipted donations (Across donors and batches) -3 Receipts need a serial number which is unique per organization

[scott-brereton]

Priority (1) related to Brad's feedback

[dsvoid]

Each donation is now only receiptable once, and each receipt has a unique ID. The UI options to receipt all donors for a batch or all batches for a donor have proven larger than expected and have been carried over into another issue (#300).

Demo Steps

• Log into DMSLite as q@q.com
• Type "Print Receipts", select a known donor and a known batch they have donated to, submit
• Type "View donations by name of known donor"
• Click the "Receipt" link present on donations that were receipted by the last print operation

[scott-brereton]

Confirmed but the process is difficult and not intuitive. Also worth noting that searching for batches, accounts and donors is having trouble with upper and lower-case letter (e.g. "stan" shows Stan Lee, but "stan lee" does not).

[dsvoid]

Added comment to #300.