Ditectrev / Practice-Exams-Platform

Practice Exams (Web) Platform developed by Ditectrev's Community.
https://education.ditectrev.com
MIT License
56 stars 14 forks source link

fix attemp #45

Closed zhuoyuT closed 1 month ago

zhuoyuT commented 2 months ago

Fixes #0000

Pull Request Type

Summary

danieldanielecki commented 2 months ago

@eduardconstantin, what do you think?

The user has reported a bug via Reddit, @zhuoyuT might you confirm that's what is the PR about?

Screenshot 2024-09-11 at 10 25 13

eduardconstantin commented 2 months ago

someone else implemented the scoring, I believe this happens because some questions have multiple answers and the score is divided by the number of answers

zhuoyuT commented 2 months ago

@danieldanielecki Hey it is, but this is not final. I commented out the shuffle function and reduced the question count for debugging purpose, I will try to update it during the weekend, but feel free to adjust on top of my commit.

@eduardconstantin the issue I encountered was the point of the last question was never added

eduardconstantin commented 2 months ago

even better

danieldanielecki commented 2 months ago

@danieldanielecki Hey it is, but this is not final. I commented out the shuffle function and reduced the question count for debugging purpose, I will try to update it during the weekend, but feel free to adjust on top of my commit.

@eduardconstantin the issue I encountered was the point of the last question was never added

thanks for the clarification, will be waiting for the next commits :)

zhuoyuT commented 1 month ago

@eduardconstantin @danieldanielecki PR updated, please check

danieldanielecki commented 1 month ago

@eduardconstantin @danieldanielecki PR updated, please check

Is it now 100% fixed & ready?

danieldanielecki commented 1 month ago

What I understood before this fix when there was a question with multiple answers correct, the total result wasn't calculated correctly. Now it should be fixed, and easily noticed by seeing 100% for such tests in Practice Mode.

Might you please confirm?

cc: @eduardconstantin

eduardconstantin commented 1 month ago

What I understood before this fix when there was a question with multiple answers correct, the total result wasn't calculated correctly. Now it should be fixed, and easily noticed by seeing 100% for such tests in Practice Mode.

Might you please confirm?

cc: @eduardconstantin

I assumed that was the issue, I haven't checked

danieldanielecki commented 1 month ago

I tested, and it was indeed the case.

However, regardless of the number of multiple-choice questions, the maximum score was always 96.67/100. Merged.

danieldanielecki commented 1 month ago

and it's no longer the case, thank you so much for the contribution @zhuoyuT

Screenshot 2024-10-03 at 10 23 02

@eduardconstantin, I also made the counter of answered questions in the top left a bit more explicit by adding ANSWERED:. Thank you as well, for the input!

eduardconstantin commented 1 month ago

and it's no longer the case, thank you so much for the contribution @zhuoyuT

Screenshot 2024-10-03 at 10 23 02

@eduardconstantin, I also made the counter of answered questions in the top left a bit more explicit by adding ANSWERED:. Thank you as well, for the input!

not a bad idea, but now the top part is not centered anymore :(

danieldanielecki commented 1 month ago

and it's no longer the case, thank you so much for the contribution @zhuoyuT

Screenshot 2024-10-03 at 10 23 02

@eduardconstantin, I also made the counter of answered questions in the top left a bit more explicit by adding ANSWERED:. Thank you as well, for the input!

not a bad idea, but now the top part is not centered anymore :(

uhh good feedback, missed it. Any idea how to handle both?

danieldanielecki commented 1 month ago

and it's no longer the case, thank you so much for the contribution @zhuoyuT

Screenshot 2024-10-03 at 10 23 02

@eduardconstantin, I also made the counter of answered questions in the top left a bit more explicit by adding ANSWERED:. Thank you as well, for the input!

not a bad idea, but now the top part is not centered anymore :(

used emoji instead https://github.com/Ditectrev/Practice-Exams-Platform/commit/5ac85c3817f1466e6997898e315455e2e1caade9 and now having best of both ;)

danieldanielecki commented 1 month ago

What I understood before this fix when there was a question with multiple answers correct, the total result wasn't calculated correctly. Now it should be fixed, and easily noticed by seeing 100% for such tests in Practice Mode.

Might you please confirm?

cc: @eduardconstantin

I meant Exam Mode of course. Practice Mode has no results shown.