Remove use of $GLOBALS['value'] in deference to global $value (PHP 8.1 interoperation).

DivaVocals / zen_Image-Handler

Image Handler 4 is really meant to ease the management of product images (particularly the management of additional product images), and to help improve page performance by optimizing the product images.

GNU General Public License v2.0

7 stars 13 forks source link

Remove use of $GLOBALS['value'] in deference to global $value (PHP 8.1 interoperation). #215

Closed lat9 closed 3 years ago

lat9 commented 3 years ago

PHP 8.1 will be disallowing $GLOBALS['value'] modifications (the construct can still be used for read-only use). See this blog-post for additional information.

drbyte commented 3 years ago

Clarification for those who read this issue: PHP 8.1 will be disallowing $GLOBALS = [] and other mass-re-assignments.

Core Zen Cart code prefers to not use the $GLOBALS['foo'] = whatever; syntax unless truly necessary, favoring global $foo; $foo=whatever; syntax instead. That's what's driving these modifications.

lat9 commented 3 years ago

Thanks, DrByte, for that clarification.