IH Admin pages: fixes and code tightening

DivaVocals / zen_Image-Handler

Image Handler 4 is really meant to ease the management of product images (particularly the management of additional product images), and to help improve page performance by optimizing the product images.

GNU General Public License v2.0

7 stars 13 forks source link

IH Admin pages: fixes and code tightening #218

Closed torvista closed 3 years ago

torvista commented 3 years ago

Fix for warning: Undefined array key "products_id" on line 39, on initial page load Addition of clause for ZC158 function name change FIx for category not being maintained on product change

The rest are html5/validation things, strict comparison checks and misc IDE inspections.

lat9 commented 3 years ago

I'll need to review these changes, since IH-5 supports zc155-zc157 and, thus, PHP versions going back to 5.6.

drbyte commented 3 years ago

Suggestion: when fixing a bug, submit a PR for "just that bug", since that can usually be merged without a lot of trouble or lengthy code-review. Then for other nice-to-haves or code-tidying, submit a separate PR, since it can be treated as "optional" by the maintainer and if they choose to not merge it then there's no negative side-effect, since the "bug" was handled separately. And for PHP-version backward-compatibility issues, yet another PR for "just those things" would be helpful as well.

torvista commented 3 years ago

Anything else to retrofit?