search

DivaVocals / zen_Image-Handler

Image Handler 4 is really meant to ease the management of product images (particularly the management of additional product images), and to help improve page performance by optimizing the product images.
GNU General Public License v2.0
7 stars 13 forks source link

Class review #228

Closed torvista closed 2 years ago

torvista commented 2 years ago

No changes to functionality. All based on IDE code inspections/complaints (based on php 7.1), intended to make real code changes later easier. Code is in production on php8 with no issues with strict checks.

I intend to do the other files (that require far less work) prior to cleaning up the use of the width/heights integers/floats etc. that are scattered about liberally but need more examination.

lat9 commented 2 years ago

Phew! That's a slew of changes; I'll need some time to review. Given that a lot of IH users are still (I know) on PHP 5.6, let's not go down the type-hinting path just yet to enable a wider audiences' use.

torvista commented 2 years ago

PHP 5.6 Good grief, and I thought I was being conservative with 7.1!

I find adding all these restrictions usually chases out something from under a stone, so they are worth it for development.

I'll reduce it to 5.6 level.

lat9 commented 2 years ago

Let me know when you've finished; we'll get any other changes after retesting after the merge.

torvista commented 2 years ago

Done.