search

DivaVocals / zen_Image-Handler

Image Handler 4 is really meant to ease the management of product images (particularly the management of additional product images), and to help improve page performance by optimizing the product images.
GNU General Public License v2.0
7 stars 13 forks source link

jscript/jscript_imagehover.js causes rest of JS to load below footer #7

Closed bislewl closed 8 years ago

bislewl commented 9 years ago

There is an issue with the jscript/jscript_imagehover.js that causes the . Then the rest of the JS is loading outside of the

DivaVocals commented 9 years ago

Your issue report seems incomplete/unclear.. Can you clarify, and since I've not seen any other reports of issues, can you provide details on how to re-create what it is you are reporting..

Finally if you have the fix, would you be willing to share via a PR??

bislewl commented 9 years ago

I actually haven't looked at a fix. However it's fairly easy to reproduce. 1.) Examine the head on a zencart store notice all the CSS/JS is loading in the head 2.) Install IH 3.) Repeating step 1 Notice how now after the jscript_imagehover.js is loaded in the head everything after it is loaded in the body.

DivaVocals commented 9 years ago

This issue is only "seen" when one uses the browsers "Inspect Element" tool.. I'm not sure this is an issue with this module.. It should be noted, that this issue is not specific to this version of IH4 which makes no changes to the image hover feature. It can also be seen in older versions of Zen Cart with older versions of IH.

bislewl commented 9 years ago

I found the solution creating a Pull request now

On Wed, Jun 10, 2015 at 12:56 AM, Crystal Jones notifications@github.com wrote:

This issue is only "seen" when one uses the browsers "Inspect Element" tool..

— Reply to this email directly or view it on GitHub https://github.com/DivaVocals/zen_Image-Handler/issues/7#issuecomment-110600945 .