search

DivadNojnarg / outstanding-shiny-ui

Outstanding User Interfaces with Shiny CRC Press book online version
https://unleash-shiny.rinterface.com
Other
224 stars 58 forks source link

Outdated demo code #52

Closed schloerke closed 3 years ago

schloerke commented 3 years ago

The CRAN versions of this application are both missing in shinydashboardPlus and bs4Dash.

https://github.com/DivadNojnarg/outstanding-shiny-ui/blob/525d2bcc8451009f23a6955729ef274272e7b8fa/shiny-input-system.Rmd#L1045-L1048

I could not easily fix the code.

DivadNojnarg commented 3 years ago

Strange. CRAN should be 2.0.0: https://github.com/RinteRface/shinydashboardPlus/tree/master/inst/vignettes-demos/box-api

schloerke commented 3 years ago

I think we can remove this line: https://github.com/RinteRface/shinydashboardPlus/blob/b8a36852a3be4d889748eb93d1a095a11efe9000/.Rbuildignore#L12

DivadNojnarg commented 3 years ago

Let me remember why I did this ;)

DivadNojnarg commented 3 years ago

Ok, that was a wrong .Rbuildignore entry. I'll push a CRAN patch for shinydashboardPlus and bs4Dash asap.

DivadNojnarg commented 3 years ago

SDB+ 2.0.2 and bs4Dash 2.0.1 are on their way to CRAN.