search

DivadNojnarg / outstanding-shiny-ui

Outstanding User Interfaces with Shiny CRC Press book online version
https://unleash-shiny.rinterface.com
Other
224 stars 58 forks source link

Missing code to `create_dependency(...)` #76

Closed schloerke closed 3 years ago

schloerke commented 3 years ago

https://github.com/DivadNojnarg/outstanding-shiny-ui/blob/ba9293faeb17d142bd5d83dfe0cc72e62c64ad88/workflow-charpente.Rmd#L370-L374

The code in 373 is missing on how to install the dependency.

schloerke commented 3 years ago

Calling create_dependency("@vizuaalog/bulmajs") creates an error

❯❯ create_dependency("@vizuaalog/bulmajs")
ℹ Trying with https://data.jsdelivr.com/v1/package/npm/@vizuaalog/bulmajs
✔ Success!
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error in create_dependency("@vizuaalog/bulmajs") :
  No assets found for @vizuaalog/bulmajs
❯❯ create_dependency("@vizuaalog/bulmajs", options = charpente_options(local = TRUE))
ℹ Trying with https://data.jsdelivr.com/v1/package/npm/@vizuaalog/bulmajs
✔ Success!
───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error in create_dependency("@vizuaalog/bulmajs", options = charpente_options(local = TRUE)) :
  No assets found for @vizuaalog/bulmajs
DivadNojnarg commented 3 years ago

Thanks for pointing this out. I'll check later what's wrong in {charpente} since it's broken:

get_dependency_assets("@vizuaalog/bulmajs", tag = "0.11.0")
$url
[1] "https://cdn.jsdelivr.net/npm/@vizuaalog/bulmajs@0.11.0/dist/"

$files
[1] name hash
<0 rows> (or 0-length row.names)

$hasSubfolders
[1] FALSE
DivadNojnarg commented 3 years ago

Overall, this example suffers from a lack of guidance. The first step is always to check get_dependency_assets("@vizuaalog/bulmajs", tag = "0.11.0") to see the repository structure. Since charpente make some preliminary assumptions, this may cause issue. For instance, we assume the repo contains minified assets, which is not always the case, especially for bulmaJS.