DivanteLtd / coreshop-vsbridge

CoreShop Vue Storefront integration - first Progressive Web App (PWA) framework for Pimcore
https://vuestorefront.io
MIT License
74 stars 25 forks source link

[BC break] feature: Coreshop store support #57

Closed dkarlovi closed 3 years ago

dkarlovi commented 3 years ago

This PR changes the configuration for the bridge to better align with Coreshop names for concepts:

Config looks like this:

core_shop2_vue_storefront:
    sites:
        example.nl:
            stores:
                - example.nl # store name, must be the same as Coreshop store name
            languages:
                - nl
        example.co.uk:
            stores:
                - example.co.uk
            languages:
                - en
        example.com:
            stores:
                - example.com EUR
                - example.com USD
            languages:
                - en
        example.de:
            stores:
                - example.de
            languages:
                - de
        example.es:
            stores:
                - example.es
            languages:
                - es
        example.fr:
            stores:
                - example.fr
            languages:
                - fr
dkarlovi commented 3 years ago

@siwamhader could you test this out to see if it makes sense for you?

ghost commented 3 years ago

@dkarlovi looks good to me.