search

DivanteLtd / magento1-vsbridge-indexer

This is an official, native Vue Storefront data indexer for Magento 1.9
https://vuestorefront.io
MIT License
18 stars 24 forks source link

Refactor for Magento EE #2

Closed qbo-tech closed 5 years ago

qbo-tech commented 5 years ago
  1. Attribute mapping fixes (categores & products)
  2. Index settings (autocomplete analyzer)
  3. Reviews indexer
  4. Category Flat Support (allows to index categories containing "include_in_menu" option)
  5. Product atrribute source fixes (select/multiselect), properly select values from eav_attribute_option_value table, allowing to index attribue text value instead of int value.
  6. Removed uneeded category attributes (reducing response size for category calls in storefront)
  7. Tests for EE 1.14 && VSF 1.5
afirlejczyk commented 5 years ago

@pkarw For now, I think we can only merge changes regarding reviews + some small fixes regarding elastic search.

pkarw commented 5 years ago

Closing for now as it's too long opened without answers and now we get into conflicts with the new changes @qbo-tech thanks for Your efforts, feel free to open new PR if You find our comments useful and would like to make this changes more general.

pkarw commented 5 years ago

There is one quick win with this PR: Reviews indexer we can take from this one and merge it to the core. Would You be willing to extract it as a nother PR @qbo-tech?

qbo-tech commented 5 years ago

Yes, will do so this week @pkarw