search

DivanteLtd / magento1-vsbridge-indexer

This is an official, native Vue Storefront data indexer for Magento 1.9
https://vuestorefront.io
MIT License
18 stars 24 forks source link

Reflecting stock_status in is_in_stock #24

Closed indiebytes closed 5 years ago

indiebytes commented 5 years ago

Filters in Vue Storefront look at at is_in_stock. In cases where a configurable product has stock_status set to 0 is_in_stock set to 1, the product will be visible in Vue Storefront but not in Magento frontend. By forcing is_in_stock to 0 like in this commit we get a more expected result with the same product listing output as in Magento.

This resolves issue #23.

afirlejczyk commented 5 years ago

Hi @indiebytes. Could you add information about this change to CHANGELOG.md ? Thank you.

indiebytes commented 5 years ago

@afirlejczyk CHANGELOG.md is now updated. I was a bit uncertain of the format, perhaps it's a good idea to add a reference to something like https://keepachangelog.com/en/1.0.0/ and if you want links to author and pull request as well? Just let me know if you want any changes to it or the PR in general.

pkarw commented 5 years ago

Thanks!