Closed cewald closed 5 years ago
Thanks for pointing this out! Can You propose a PR with this change please?
@cewald thank you for pull request
@pkarw
In a clean Magento installation, this table is not empty..
I will double check this. For now, I found Magento data installer which is adding data to this table.
But sure, the error shouldn't appear at all :)
@afirlejczyk Alright. As i know these tables are used to save "non-eav" product relations like cross-sell, up-sell or grouped products – if you don't have them in use, this tables are empty. But if you use the sample data of magento, there will be sample data in this tables after installation. I double checked it with a plain installation with sample data. But it's definitely good to be sure ;)
If I run
php shell/vsf_tools.php --action full_reindex --action full_reindex --store 1 --type products
the following exception is thrown:Reason: I found out that this happens because our
catalog_product_link_attribute
table is empty and the select is return false instead of an array in class methodDivante_VueStorefrontIndexer_Model_Resource_Catalog_Product_Links::fetchPositionAttributeData()
(line 209-220, source link).Solution I changed the class method
joinPositionAttribute()
to continue if an empty array is returned byfetchPositionAttributeData()
:Maybe this should be considered in the code by default if somebody isn't using upsell- or crosssell-products.