search

DivanteLtd / magento1-vsbridge

Run the Progressive Web App (PWA) on top of Magento 1.9. This is a Vue Storefront bridge for Magento 1.x. MIT License
https://vuestorefront.io
MIT License
57 stars 49 forks source link

Add RewriteController to allow easy handling of historic rewrites #37

Open nhp opened 5 years ago

nhp commented 5 years ago

Added a new controller to be able to access the old rewrites vsf-api knows nothing about. It simply makes a DB call to core_url_rewrite, filtered by request_path and returns only the new final target.

Usage

Simply called by /vsbridge/rewrite/target?request_path=old_url this returns {"code":200,"result":"target_path"}

As we agreed with Łukasz Romanowicz on slack we should bring this functionality to the main magento1 trunk.

nhp commented 5 years ago

Also added store_id handling as this could also be an issue and we added more specific result-status codes to reflect on what really was the problem instead of only returning 200 and especially 500.

nhp commented 5 years ago

Do we still have open issues here?

nhp commented 5 years ago

Any update on this one?

ResuBaka commented 5 years ago

Here I have found a small Problem. I will Update the PR in the next days.

sandermangel commented 5 years ago

@ResuBaka hi! any update on the PR changes?

ResuBaka commented 5 years ago

I will update in the next days.

The problem is that I need to send the request URLs html encoded.