Diversido / flutter_twilio_conversations

Integrate the Twilio Conversations SDK with your Flutter app using this Twilio Conversations Flutter plugin
7 stars 7 forks source link

Web Support #30

Closed NicParmee-Kena closed 4 months ago

NicParmee-Kena commented 4 months ago

Fixes: #27 This is a large pull request as it adds support for web.

A platform interface has been implemented that directs requests to the appropriate platform specific package. The android and iOS packages have been left in the original flutter_twilio_conversations folder to reduce changes on this PR.

A web specific package has been developed that integrates with the twilio-conversations.min javascript library and provides a mapper between dart and the library.

N.B. For publishing, as it is now a federated plugin, steps will need to be taken to publish each package without dependency on one another and subsequently add their dependencies once they are published and available.

asmodeoux commented 4 months ago

overall looks really good! is this ready to be merged? if not let's mark it a draft until the final commits are pushed

UPD. oh I see, we have to fix the path dependencies first, marking this as draft yet

NicParmee-Kena commented 4 months ago

@asmodeoux we have resolved the path dependencies and if you are happy and ready should be able to publish the platform interface

asmodeoux commented 4 months ago

@NicParmee-Kena I see the path dependencies are still there but everything else looks good. Should I publish all 3 folders as separate packages depending on each other or do you mean there's some other solution?

NicParmee-Kena commented 4 months ago

@asmodeoux sorry what I mean is the platform interface doesn't depend on any of the other packages anymore - so it can easily be published first. No other solution that I know of. Thank you very much.

asmodeoux commented 4 months ago

All 3 updated packages are now published:

Thank you very much for the contribution and congratulations! 🎉 Hopefully nothing breaks haha