Divested-Mobile / DivestOS-Build

Everything needed to build DivestOS, a more private and more secure aftermarket mobile operating system.
https://divestos.org/index.php?page=build
Other
226 stars 31 forks source link

Latest update appears in the list even device is up-to-date #316

Closed attisimon closed 4 months ago

attisimon commented 4 months ago

Hello!

Device: Google Pixel 3 (blueline) OS: 20-20240615-dos-blueline

First of all, I want to report back that this device can be locked successfully.

Second, the issue is that, although I initially installed the latest version (20240615), when checking for updates, the same version appears as update. I downloaded it, installed it, rebooted the device, but the update is still in the list as waiting for being installed.

There is no error message, device is working, installation takes some time and I kept an eye on it to see if there is anything displayed, but nothing out of the ordinary is seen.

These are the stages: Downloading update, Confirming to apply update, Preparing for first boot, Finalizing package installation, Reboot, Update still there as if it was not installed.

Screenshot Screenshot Screenshot Screenshot Screenshot Screenshot Screenshot
SkewedZeppelin commented 4 months ago

This is intentional and expected. https://divestos.org/pages/broken#notes

The Updater will show the currently installed update, this is expected.

You can delete the update once installed.

steadfasterX commented 4 months ago

This is intentional and expected. https://divestos.org/pages/broken#notes

The Updater will show the currently installed update, this is expected.

You can delete the update once installed.

Interested on a fix for that ;) ? I stumbled over that issue one long ago when offering my first OTA's.. its quite easy to fix but I dont know if u really want it that way or not @SkewedZeppelin

SkewedZeppelin commented 4 months ago

It is not a bug. It makes it easy to install the update again to the other slot if necessary or to verify that update capability still works.

steadfasterX commented 4 months ago

It is not a bug. It makes it easy to install the update again to the other slot if necessary or to verify that update capability still works.

True, its not a bug but its not intentional or how it is meant to be.

You found some valid points to keep it like that though and it is like you want to have it and thats fine. Thats why I've asked. All good

attisimon commented 4 months ago

This is intentional and expected. https://divestos.org/pages/broken#notes

The Updater will show the currently installed update, this is expected.

You can delete the update once installed.

I already had the latest version, but I downloaded the update and installed it, thinking that I missed somthing. Then if I delete it, it will still appear in the list, available for download.

I understand that this is something good to have for testing, but it is still confusing, not the expected behavior. So, this is out of the ordinary, but I'll have to accept that this is how it is done in DivestOS.

attisimon commented 4 months ago

I would also like to add, regarding future updates and allowing the bootloader to be unlocked, I would suggest to add an extra message about this before starting the update process, similar to the one in the second screenshot.

Not everyone is willing to keep OEM unlock "on", but it could be briefly done before each update, just to make sure.

I know this is user specific, but because this is again out of the ordinary, an extra message would be of help.

Thanks!

SkewedZeppelin commented 4 months ago

Not everyone is willing to keep OEM unlock "on",

There is no downside to this. Anyone attempting to unlock the device will still cause a wipe to be invoked before the actual unlock happens. DivestOS only recommends you keep it enabled.

DivestOS has occasionally bricked devices, without this option your device will be permanently bricked. eg. https://divestos.org/pages/news#2022-01-incident

but it could be briefly done before each update,

Do not toy with that toggle like this, it is special and changes values as a stripe in a special partition.

attisimon commented 4 months ago

There is no downside to this. Anyone attempting to unlock the device will still cause a wipe to be invoked before the actual unlock happens.

Yes, a wipe will make sure the data disappears, but the device will still be usable, the perfect scenario for thieves, for example.

I understand that there is a risk for bricking the device, that is why I thought of going on the middle ground, keep OEM unlock off, but turn it on only when there is a risk of bricking ahead and after this risk has passed, turn it off again.

Are there any serious implications of using this toggle before and after every OTA update?

SkewedZeppelin commented 4 months ago

but the device will still be usable

A wipe can be invoked regardless.

Are there any serious implications of using this toggle before and after every OTA update?

Do not do this.

SkewedZeppelin commented 4 months ago

To be clear: You gain nothing by turning off OEM unlocking.

You risk:

attisimon commented 4 months ago

A wipe can be invoked regardless.

Is this the case with any Pixel with stock os, or only for DivestOS?

Thanks for all this info, I made a note.

SkewedZeppelin commented 4 months ago

Why do you think a wipe can't be invoked? A wipe can always be performed.

Just boot into the recovery and see there is a factory reset option.

The stock OS however has Google Play Services, which offers Factory Reset Protection. ie. it phones home to Google to see if it was logged out first or not and demands signin again if it wasn't logged out before reset.

attisimon commented 4 months ago

I wasn't sure about the precise details, but I knew that there was something there against theft/reselling-stolen, but your reply cleared my thoughts. Thanks!