search

Divested-Mobile / DivestOS-Build

Everything needed to build DivestOS, a more private and more secure aftermarket mobile operating system.
https://divestos.org/index.php?page=build
Other
226 stars 31 forks source link

Can not select adb root but service is running, please remove adb root prop #357

Closed NgoHuy closed 1 week ago

NgoHuy commented 1 week ago

As I see that we can search adb root from developer mode, but it redirects to developer options, we cannot select it. But the prop [init.svc.adb_root]: [running] is still exist. Please remove this prop to prevent some misfunction about ADB root

SkewedZeppelin commented 1 week ago

adb root is not supported on DivestOS and cannot be used

NgoHuy commented 1 week ago

I understand that adb root cannot be used. But our rom still show prop about adb_root. It leads to some misfunction about root status. Please remove it from your build.

SkewedZeppelin commented 1 week ago

The service runs regardless and advertises its state as not rooted. Just because the name has root in it doesn't mean the device is rooted. If an app is checking that property it is bad.

NgoHuy commented 1 week ago

firstly, [init.svc.adb_root]: [running] it means adb init as root, and this prop is useless when we dont have root. It leaked many false detections. Why do you set it when we dont need it? It means our rom is debuggable build? right

SkewedZeppelin commented 1 week ago

no, DivestOS primarily ships non-debuggable -user builds. again this is just how it is, not going to change.

if you have a specific app that isn't working or specific device, please state it.