DiviProject / Divi-Desktop-Public

Public, open source development repository for the Divi Desktop Smart Wallet
GNU General Public License v2.0
7 stars 6 forks source link

"Combine UTXOs" dreaded red button of doom #195

Closed Divicoin closed 3 years ago

Divicoin commented 4 years ago

First off we need to change the name of this button. nobody knows what a UTXO is. It should be either Combine unspent, or even better, combine received(since to be unspent you first have to receive it and it will make more sense to most people). More importantly though:

Ideally I think combine shouldn’t ask the user if they wanna use it unless they check a case by case box. They can also check an always box and then it does it always. Or they can check an as needed box which will only do it if otherwise it will exceed the size. If nothing is checked it should never do it but should prompt an explanation when it can’t send asking them if they want to do it (they likely will cause otherwise they can’t send). The flow right now has caused numerous issues.

when the combine utxo modal pops up, it asks you to answer “yes” or “cancel”. imo it should be “yes” or “no”. cancel makes it seem like you’re cancelling the whole send

We should also have an option to only combine what's needed for the transaction...so a 500k divi transaction should combine enough utxos to send that, but not combine the whole wallet, say 5 million.

Divicoin commented 4 years ago

➤ The Voice commented:

I would say this option should be hidden unless the user checks the advanced box

There is already a function for this so as we update this button for a modal or tooltip lets hide it also

Divicoin commented 4 years ago

➤ Wrike Bot commented:

Elías Gómez All the necessary task dependencies have been completed, so you can start working on it right away.

Divicoin commented 4 years ago

➤ Ori Zeiger commented:

Yeah I'm good with hiding it. The "auto" part of the suggestion might require separate task. I have also talked to German about potentially doing this via the core, but, that's going to take longer.