Open oriz456 opened 5 years ago
➤ Eugene Ilagin commented:
Nick Saponaro our answers are inline in . Please take a look
-Regarding the backup or recover flow: when you start from scratch there definitely should be an option to recover OR backup(not "and" though), this was removed and only backup was left. However this should be a separate modal than the one that comes up when you go to encrypt if your wallet is not backed up yet, that particular modal should only have a backup option(since there's nothing to recover and it's confusing).
Also,Is there any reason why "security" is not accessible while a new wallet is loading?
-I like the email alot better now, there just seems to be a slight issue with the way the links show.
if wallet is unlocked for staking only, and you try to enter console, it will pop up a modal to unlock. However, even if you just "x" the modal and don't completely unlock, it will bring up the console anyway.
EDIT: the same thing happens for masternode dismantle or unsubscribe as well. I'll try to see if I can find more.
-it looks like if you lose internet connectivity, likely due to cache(?) it will show at the bottom fully synced, even if you have no peers at all when trying to connect again(I had to restart daemon). DONE
Instead maybe it can say something like please be sure you have proper backup? also, maybe if it’s someone that has never done the backup process, it can ask them to back up first. we really need to idiot proof this. Other than that uninstall process works great. DONE
-Apparently at some point we moved away from showing the number of confirmations when hovering over the transaction info to something like “4 confirmations before spendable”. I don’t like it. It’s lengthy and I don’t really see what value it adds - why not just have it show “2/6 confirmations”. DONE
-I’m still getting emails about a masternode I had over a month ago that isn’t even in my local masternode.conf anymore, telling me it’s down. The masternode was never technically dismantled but the wallet was nuked. We currently don't have abulity to track manually removed masternodes. The remote backup server would consider a MN existing if a config line had been removed manually. In case this is an issue - please create a separate task so we'll think how to resolve it.
-Still regarding the email, ideally I think we should provide more than info if masternode is down. For example, a weekly email with summary of your rewards that week, or you could opt to do it daily or even each time you receive a reward(overkill for me, but some might want to). Also would be cool to do that via sms. Weekly email and SMS are quite a big features. We suggest doing that in a separate task scope if required.
-Honestly I don’t like the structure of the email. I would change it from this:
Hello Ori,
There seems to be a problem with your Divi Desktop MOCCI node. This is normally a server issue.
In order to avoid an interruption in rewards, you should open Divi Desktop, navigate to the Masternodes tab, and click the Lightning Bolt icon to restart your MOCCI.
If that doesn’t work, try Dismantling and Redeploying the node.
If you still have questions, please join us on our support channel: https://t.me/divisupport
more to something like this maybe?
Hello Ori,
There seems to be a problem with your Divi Desktop MOCCI node. There are several reasons why this could happen, most commonly a server issue.
In order to avoid an interruption in rewards and troubleshoot the issue, please join us in our support channel: https://t.me/divisupport. Alternatively, you can also request support in our forum: https://forum.diviproject.org/c/support.
You could also attempt to dismantle and redeploy your node on your own, however receiving the proper guidance is highly recommended.
Thank you, Divi Project Team
there is no need to tell them to start the masternode at all. DONE
-Also regarding email, it’s great that the address is noreply…but the name shows up that way too. I can’t speak for everyone, but for me personally it’s alot easier to miss “noreply” emails as opposed to an email with an actual name. It should probably say “Divi Project Masternode Notification” or something of that sort instead of just noreply. DONE
-When primer is done and daemon is restarted, the modal remains and you have to manually click close. Why not have it auto close? DONE
-Also primer right now only talks about out of sync wallets. When it pops up on someone’s first attempt at the divi client, I have seen it confuse more than one person. Why not add something in there saying “this is recommended for new wallets in order to sync with the blockchain faster”. Or better yet, for new wallet maybe a popup “how would you like to sync with the blockchain” providing both options - primer, or p2p(but with an easy to understand description of the two and the differences between them). DONE
-“user” requiring unlock with modal that includes unlock for staking. we should probably switch it to the same modal we switched unlock for 2fa to because unlocking for staking won’t help you enter “user info” at all. DONE
-For 2fa allow one click copy of manual code. DONE
-In the wallet history or overview when going into a transaction and clicking on the txid it takes you to defunct diviscan page…should switch to chainz. It is unclear where the click should lead to. Please provide additional info
–When you start from scratch with a new wallet, there is no automatic prompt for recovery modal anymore(probably because the default now is the lone “backup”) and no option to go into “Security”(it’s inaccessible while wallet is loading) you have to wait for the completely new wallet to load just to recover by seed. I didn’t have a problem with the “wallet loading” screen having both before, I just think they should say “backup or recover from seed” as opposed to currently saying “backup and recovery from seed”. However where it gets tricky is if you’re in an unbacked wallet, and you go to encrypt, it would ask you to “backup or recover” which was very confusing. So ideally, we should bring back the “backup or recover” screen for firing up, but have a DIFFERENT, “backup only”(the one we have right now) screen for when you click encrypt with a non backed up wallet if that makes sense. That, and/or allow access to security before the wallet loads. Some time ago we disabled that flow. Please decide if this should be redone
-if you click on the lock when it’s unlocked for staking it opens up modal to unlock…I think the right sequence should be a click on unlocked for staking will lock it(much like a click on completely unlocked wallet locks it). and then another click will let you unlock it(much like clicking on a locked wallet does). there is really no way to go from unlocked for staking to full lock unless you do it through settings. another option is to have the “unlock modal” itself also include an option to lock the wallet. Unfortunately the core doesn't allow to completely lock the wallet from "Unlocked for Staking only" state.
-no option to actually send through address book…you have to copy the address and go to “send”…maybe next to all the options “copy” etc, we can have a “send to” option which will open up a modal(with a similar look to the “regular” send screen) for a quick send where you just enter the amount and go. DONE
-we don’t have a save button, we click update network.
DONE