DiviProject / Divi-Desktop-Public

Public, open source development repository for the Divi Desktop Smart Wallet
GNU General Public License v2.0
7 stars 6 forks source link

Emails sent for manually removed masternodes #73

Open oriz456 opened 5 years ago

oriz456 commented 5 years ago

If a masternode is manually removed or client is uninstalled, notifications are received saying the node is down. need a way to track manually removed masternodes if possible.

Divicoin commented 4 years ago

➤ Abigail Loaiza Rojas commented:

Hi, will it work for test net?

Divicoin commented 4 years ago

➤ Eugene Ilagin commented:

Hi Abigail Loaiza Rojas emails are only sent for livenet nodes

oriz456 commented 4 years ago

So there used to be emails sent for testnet nodes as well, wehich is how we found ths issue to start with. I am not sure how we can test a possible resolution if we cannot do it with testnet nodes?

Divicoin commented 4 years ago

➤ Eugene Ilagin commented:

Email sending service relies on 2 things: 'listmasternodes' rpc call and diviscan. Unfurtunatelly testnet masternodes are not being shown in diviscan and are constantly being dropped from 'listmasternodes' result output so we cannot rely on it.

oriz456 commented 4 years ago

It appears I am receiving emails for them again; However, would it be possible to add to the email which node it's pertaining to? for one - in order to properly test it would help(that way I can differentiate between my nodes that are being dropped on their own, and a node I'll remove myself) and for two, I am sure it will be useful for users who are deploying more than one masternode.