search

Divide-By-0 / autolatex

All Auto Latex Equations Versions.
https://autolatex.com
MIT License
17 stars 1 forks source link

Fixes for table equation rendering #4

Closed grimsteel closed 1 year ago

grimsteel commented 1 year ago

Changes:

Because there's no simple way to get the position of a table cell, all of the table equations are positioned over the first cell

Questions:

What is this for loop fixing? Why do you need to do 5 passes?

https://github.com/Divide-By-0/autolatex/blob/1e13acca16647489e595f865820e7c7dffa6edb7/Slides/Code.js#L151-L159

I'm getting the "Sorry, the equation is too long or another problem occurred." error a lot, even though all of the equations are being rendered. Do you know why this is?

Divide-By-0 commented 1 year ago

Ignore the 5 passes, you can delete that -- that's just poor code practice to try to get it to run even when it fails.

I'm getting the "Sorry, the equation is too long or another problem occurred." error a lot, even though all of the equations are being rendered. Do you know why this is?

This is probably because it encounters a "Drawing" object somewhere. I just pushed to master -- I would recommend pulling the newest master, and logging the value of "c" which is the variable that determines the error message. I believe it was being calculated incorrectly and I partially fixed it.

Divide-By-0 commented 1 year ago

Here's the PR where I try to fix that the Slides add-on errors even on success: https://github.com/Divide-By-0/autolatex/pull/5

Lmk if it works for you -- I think there's still some bug I wasn't able to debug.

grimsteel commented 1 year ago

It looks like you made that branch off of master while I made the branch for this PR off of Dev-Tables (The doc that you sent me looked like it described Dev-Tables) and it seems like master and Dev-Tables are very different now

There's also a different yet similar (lol) solution for parsing all the table cells in your branch. Should I branch your branch and apply my changes for the font color there?

Divide-By-0 commented 1 year ago

Oh they're not actually very different, it's just a linting change -- only like 20ish lines actually changed, the rest are spacing changes. Merging these changes into there would also make sense -- whatever's easiest for you!