Closed Divide-By-0 closed 1 year ago
Because I made really small changes in #4 I found it easier to just manually apply them here as I fixed the bugs.
Cool! Does everything work now?
Hopefully! I tested:
I'll work on shapes next
Shapes (and really anything that's not a text box) should not be deleted if they don't have any text left after the equation is rendered now
I also added support for recognizing vertical and horizontal text alignment in shapes and text boxes (not tables because it just drops those equations at the top left regardless of cell position)
You can merge this if you want, and I'll start working on unifying Docs and Slides
What if the shape has text and drawing, and the text is rendered but there's drawing left?
I think I misunderstood what you meant by drawings. How do you insert a drawing into a shape in Slides?
See the slides that I shared with you! Those have a drawing and mess up your rendering.
Edit: Given the new changes, it's actually now OK.
Is this the drawing you're talking about: If so, I still don't understand what you mean. Could you show me an example of how it looks before the equations are rendered?
Also, I'm in the process of making the common library. What do you want me to do about reportDeltaTime
? It's most of the functions in Docs but not in Slides.
reportDeltaTime is very useful for logging -- we should add it to analogous functions in Slides as well. It is totally general so feel free to leave it as a shared function that's identical.
Hey, it looks like the drawing issue is fixed.
Here is the original.
Here is the replaced (colors are inverted in my Chrome, don't worry about that).
Two additional features we'd want:
1) When replacing an equation with an image, calculate the width of that image and insert that number of spaces into the textbox where the equation was lifted from. 2) For equations with multiple colors, detect that and color each section accordingly.
Temporarily merged, will continue to remerge as you make PRs.
try to fix the error where accounting of equations is incorrect, so it errors on success lots of small lint fixes there still seems to be some bug where things fail, requires more logging of the exectuion trace to figure out