search

DivideBV / Postnl

Library to connect to PostNL's SOAP service called CIF
GNU General Public License v2.0
31 stars 40 forks source link

Implement PostNL deliverydate webservice #21

Closed danslo closed 8 years ago

danslo commented 8 years ago

As a followup to the location webservice, here's also the implementation for delivery date webservice.

I hope I got this right on my first attempt. If I missed anything, please let me know!

ameenross commented 8 years ago

Thanks for another contribution!

I wrote a few comments, and there's a merge conflict that needs resolving.

ameenross commented 8 years ago

I got a little confused, commits 2 days ago appear after my comment of 18 hours ago in the timeline :)

I take it you rebased it on master instead of merging?

danslo commented 8 years ago

Yeah sorry, rebased because of the conflict and wanted to preserve clean commit history.

ameenross commented 8 years ago

It looks good.

On an unrelated note, do you happen to know of a complete list of all the services that are part of CIF? I'd like to at least document which services are implemented in this library and which aren't.

danslo commented 8 years ago

I just know about the ones listed here.

ameenross commented 8 years ago

Huh. I don't think that was there when I first started implementing... Thanks

ameenross commented 8 years ago

Meh. Some code style violations slipped through. My bad, should have run Grunt before merging.