search

DivideBV / Postnl

Library to connect to PostNL's SOAP service called CIF
GNU General Public License v2.0
31 stars 40 forks source link

Add support for 'CV' barcode type #7

Closed JeroenBakker closed 8 years ago

JeroenBakker commented 8 years ago

As discussed in the issue, there is a barcode type that may or may not be documented, it seems an up to date version of the documentation is hard to come by.

Dropping the sanity check is a viable alternative, but I do have to admit PostNL's own error messages in the case of an actual wrong barcode type aren't very helpful so it does serve a purpose.

As this is my first time submitting a pull request via GitHub, please let me know if I missed anything anywhere.

ameenross commented 8 years ago

Thx for the contribution. Please remove the 2 redundant commits, then I'll be happy to merge. Don't forgot to force push.

JeroenBakker commented 8 years ago

I removed the redundant commits, we use hg at work so it took some googling, but it wasn't that tricky in the end, thanks for the suggestion.