DivideBV / Postnl

Library to connect to PostNL's SOAP service called CIF
GNU General Public License v2.0
31 stars 40 forks source link

GB is not EU anymore, please remove GB from PostNL->countryCodeMapping #82

Closed Hill103 closed 3 years ago

Hill103 commented 3 years ago

In order to be able to generate a 4945 label, i had to remove GB from the EPS product list.

Could you remove GB from the list, since it's not EU anymore and the 3S codes won't work.

protected $countryCodeMapping = [
        // Dutch domestic product.
        'NL' => '3S',
        // EPS products.
        'AT' => '3S',
        'BE' => '3S',
        'BG' => '3S',
        'CZ' => '3S',
        'CY' => '3S',
        'DK' => '3S',
        'EE' => '3S',
        'FI' => '3S',
        'FR' => '3S',
        'DE' => '3S',
        // 'GB' => '3S',
        'GR' => '3S',
        'HU' => '3S',
        'IE' => '3S',
        'IT' => '3S',
        'LV' => '3S',
        'LT' => '3S',
        'LU' => '3S',
        'PL' => '3S',
        'PT' => '3S',
        'RO' => '3S',
        'SK' => '3S',
        'SI' => '3S',
        'ES' => '3S',
        'SE' => '3S',
        // Everything else is GlobalPack.
    ];
ameenross commented 3 years ago

Fair enough... simple fix.

Tagged 2.0.2