search

DivinElegy / GrooveNights

ITG Theme
http://divinelegy.com
8 stars 5 forks source link

Make speedmods use none (or significantly less) global vars #7

Closed ghost closed 10 years ago

ghost commented 10 years ago

Should be possible to get it not using global vars at all. It's just a bit more complex to implement than rate mods though, as the multi line speed mod thing uses globals quite a bit.

ghost commented 10 years ago

Change GetSpeedMod to look at every speedmod before returning, get it to build up a table of applied speedmods or something. That way I can look at what is supposedly applied and maybe determine which value to really return.

The bug can be replicated by setting 0 as the X mod, then changing mod type to M-Mod, then changing extra speed to 0.25. The speed won't change to 250, but instead will be 0.25 the BPM of the song, since GetSpeedMod is returning the current speed mod as 0x still

Seems like if I have 0x AND a non zero M-Mod, then use the M-Mod and if I have M0 and a non zero X mod, then use the X mod.