DivineOmega / password_exposed

🔒 Password Exposed Helper Function - Check if a password has been exposed in a data breach.

GNU Lesser General Public License v3.0

213 stars 34 forks source link

Test enhancement #16

Closed peter279k closed 5 years ago

peter279k commented 5 years ago

Changed log

Upgrade PHPUnit version to ^6.5.
Add php: >=7.0 in require block and define this in composer.json.
Add the test classes namespace in autoload-dev block and define this in composer.json.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 108

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.362%

Totals
Change from base Build 99:	0.0%
Covered Lines:	42
Relevant Lines:	47

💛 - Coveralls

peter279k commented 5 years ago

@DivineOmega, the Travis CI build work is failed.

It looks like the php-7.0 test is failed because the cURL handshake is failed.

The Exception message is as follows:

GuzzleHttp\Exception\ConnectException: cURL error 35: gnutls_handshake() failed: Handshake failed.

Do you have any idea about this solution?

It looks like it's the certificate issue after reading this issue and this issue you've commented.

Perhaps we can update the certificate before running phpunit in Travis CI build.

DivineOmega commented 5 years ago

@peter279k This is actually a bug with Travis not being able to perform PHP Curl requests to HTTPS URLs in PHP 7.0.

See here for more information: https://github.com/travis-ci/travis-ci/issues/6339

This was why PHP 7.0 is not in the .travis.yml file.

DivineOmega commented 5 years ago

Feel free to just remove PHP 7.0 from your .travis.yml.

peter279k commented 5 years ago

@DivineOmega, thank you for your reply.

You mean we just skip the php-7.0 test in Travis CI build?

How can we ensure the php-7.0 can be worked well? Perhaps this package will add php: "^7.1" for require block in composer.json.

DivineOmega commented 5 years ago

@peter279k I think we might have to just skip PHP 7.0. I don't want to increase the minimum version the package supports, as I know many web applications are still (unfortunately) using PHP 5.6.

I would suggest just skipping PHP 7.0 for now to get this merged.

peter279k commented 5 years ago

@DivineOmega, just notice you I've removed php-7.0 test in .travis.yml and let this package require php-7.1 version at least. It defines in composer.json.

DivineOmega commented 5 years ago

Thanks!