Closed tacovandenbroek closed 5 years ago
This looks good to me. Thanks. 👍
Would you mind adding some tests specifically for the passwordExposedByHash
method, and then I'll get this merged? Feel free to just copy the code from PasswordExposedTest.php
and supply the method with pre-hashed values instead of the plaintext password.
After some trouble with the styleci check, I've managed to add those tests ;)
Thanks for adding the tests! 🙂
Just added some documentation for the new method. This will go into a new release shortly.
However unlikely, passing a real password to a library is a risk in itself. Since there is no need to do that in this case we should provide a method to check a password by it's SHA-1 hash.