DivineOmega / password_exposed

🔒 Password Exposed Helper Function - Check if a password has been exposed in a data breach.
GNU Lesser General Public License v3.0
215 stars 34 forks source link

Laravel 5.7 incompatibility #25

Closed DivineOmega closed 5 years ago

DivineOmega commented 5 years ago

It seems this package should not indicate support for v1 of the guzzle6-adapter package, because the type of object returned differs between v1 and v2 of the guzzle6-adapter.

This causes a compatibility issue with Laravel 5.7

It is caused by Laravel 5.7 requiring the laravel/nexmo-notification-channel as standard, which depends on the nexmo/client which enforces the use v1 of the guzzle6-adapter.

My plan of action is going to be:


This issue was discovered by @tswestendorp. See https://github.com/DivineOmega/password_exposed/pull/24.

DivineOmega commented 5 years ago

If you need to use this package in Laravel 5.7 before this is fixed, feel free to install v2.8.0, which is not affected by this issue.

DivineOmega commented 5 years ago

@tswestendorp This is now released as v3.0.1. Would you mind double checking this release is working as expected for you?

tswestendorp commented 5 years ago

@DivineOmega Still perfect! Thanks!

DivineOmega commented 5 years ago

@tswestendorp Excellent. Thank you for testing.