search

DivineOmega / uxdm

🔀 UXDM helps developers migrate data from one system or format to another.
GNU Lesser General Public License v3.0
167 stars 9 forks source link

Doctrine destination #10

Closed rvmourik closed 6 years ago

rvmourik commented 6 years ago

So it can be used with Symfony

DivineOmega commented 6 years ago

Started work on this in the doctrine branch.

rvmourik commented 6 years ago

Very good!

DivineOmega commented 6 years ago

Pretty certain I've got a functional Doctrine destination in that branch now.

@rvmourik Would you be able to take a look / do some tests? If it looks good I'll write up some documentation and merge it to master.

rvmourik commented 6 years ago

@DivineOmega don't have enough time to clone the project and check the code, but i reviewed it quickly and it does look good. I've added a comment at one of the commits.

Also is see you make us of doctrine/orm 2.5.x, is there a reason why you're not using 2.6?

DivineOmega commented 6 years ago

@rvmourik Thanks for the feedback.

I'll consider the property access package you commented about here: https://github.com/DivineOmega/uxdm/commit/9ebef9177fcb69223bd70e6c067b7e62cc9ceee2#r29179392. Looks pretty useful.

You're right, I should be using 2.6. There was no good reason for using 2.5. I'll up the minimum version number as well.

DivineOmega commented 6 years ago

This is now using Doctrine ORM 2.6 and the symfony/property-access package to call the setter methods.