search

Divinelink / scenepeek-android

ScenePeek is an Android Application that provides information about movies, television shows & persons using the TMDB API.
0 stars 0 forks source link

[Enhancement] Add support for multi info (TV-Series-Persons) search #29

Closed Divinelink closed 7 months ago

Divinelink commented 1 year ago

In this PR we enhanced the search functionality to also include TV-Series and Persons. This is accomplished by leveraging the multi-search API.

We had to thoroughly update our logic in order to make everything more generic and also introduce some custom deserializers.

Additionally, most of android test are now unit tests by leveraging the robolectric framework. This reduces the time required to finish the test suite by quite a decent amount of time.

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 56.40466% with 599 lines in your changes are missing coverage. Please review.

Project coverage is 50.53%. Comparing base (4cc8e64) to head (307b021).

Files Patch % Lines
...ase/data/remote/movies/service/ProdMovieService.kt 0.00% 63 Missing :warning:
...ta/remote/movies/dto/details/DetailsResponseApi.kt 46.72% 49 Missing and 8 partials :warning:
...dreolas/movierama/base/communication/RestClient.kt 0.00% 33 Missing :warning:
...movierama/base/data/local/popular/PersistableTV.kt 0.00% 31 Missing :warning:
...andreolas/movierama/home/domain/model/MediaItem.kt 53.73% 31 Missing :warning:
...las/movierama/details/domain/model/MovieDetails.kt 56.45% 26 Missing and 1 partial :warning:
...home/domain/usecase/FetchMultiInfoSearchUseCase.kt 25.71% 24 Missing and 2 partials :warning:
...earch/multi/mapper/MultiSearchResponseApiMapper.kt 0.00% 24 Missing :warning:
...ama/home/domain/repository/ProdMoviesRepository.kt 48.93% 24 Missing :warning:
...olas/movierama/base/data/local/popular/MovieDAO.kt 27.58% 18 Missing and 3 partials :warning:
... and 38 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ============================================ - Coverage 56.16% 50.53% -5.63% + Complexity 240 214 -26 ============================================ Files 108 119 +11 Lines 3887 4316 +429 Branches 508 572 +64 ============================================ - Hits 2183 2181 -2 - Misses 1403 1825 +422 - Partials 301 310 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.