Please review part 2

[DiyahM]

Please review my app cc/ @nesquena and @timothy1ee

[nesquena]

Ran into several issues with your project:

• LoginActivity was failing for me when I launched it. It's an issue with timing. The first time you launch the app, https://github.com/DiyahM/android_twitter_client/blob/master/src/com/codepath/apps/diyahtwitterapp/LoginActivity.java#L61 fires before the current user is found (since its async) and therefore the user is null and the whole thing fails. Moving that code into the user credentials on success fixes the issue.
• Entering mentions raises a null pointer exception because it can't find the twitter client. Paginating on mentions was broken. getMoreTweets only works for the home timeline so mentions cant properly paginate. See: https://github.com/DiyahM/android_twitter_client/blob/master/src/com/codepath/apps/diyahtwitterapp/fragments/TweetsListFragment.java#L62
• Pagination on user profile is also broken, getting exceptions every time I scroll

The core of why the app appears entirely broken is the endless pagination which isn't properly configured to work across different timelines. There are many approaches to fix this including setting up an abstract method (i.e loadMoreTweets) in the base fragment and have the individual extended timelines implement the proper way to load more tweets.

Overall it looks really close code-wise though. If you need any help addressing these issues, maybe we can chat today before class if you can come in a little early? Otherwise maybe after class.

[DiyahM]

Sorry, about that. This was a case of me being very last minute and not paying attention carefully. I had to erase my user data on my emulator to see the error. I just pushed some changes, and these issues should be fixed. At minimum, the app should be functional now, but I do need to go back in to refactor and make it a bit more dry. Please let me know if these new changes work. Thanks!

[nesquena]

:+1: Hi Hadiyah, thanks for fixing it up working much smoother now. Few points of feedback:

• Used FrameLayout to act as a container for timeline tab content
• Setup ActionBar Tabs mode with the Home and Mentions timeline tabs
  • Should checkout tabs cliffnotes to see how you might do this in a Gingerbread compatible way and using a "FragmentTabListener" which is recommended approach by Google.
• Setup the base fragment class that the timelines all extend from
• OPTIONAL: Could move the setOnScrollListener for endless into the base class and make getMoreTweets an abstract method
• Setup home timeline fragment without much unnecessary code duplication
• Setup mentions timeline fragment without much unnecessary code duplication
• Setup endless pagination that works across all three timelines
• Properly setup user profile view with profile header and a user timeline fragment
  • Can view my profile by clicking on the ActionBar
• Clicking on a users profile image takes me to their profile
  • Sets click handler in adapter
• BUG: Compose posts but crashes (when I hit tweet, it raises a null pointer exception in the timeline result)
• OPTIONAL: Right now if I click on a friend's profile and then click on their image again in their profile, it opens up a second profile. This sort of profile recursion is kind of odd from the UI perspective, real twitter client disallows stacking up navigation to the same user's profile over and over
• OPTIONAL: Should play with ActiveAndroid for persisting latest tweets

Nice work overall, hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, .

Things are almost coming to a close now and I hope you've found the bootcamp valuable. Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Sept 30th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group apps that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.