search

Dj-Corps / gwt-oauth2

Automatically exported from code.google.com/p/gwt-oauth2
Apache License 2.0
0 stars 0 forks source link

Facebook oauthWindow.html doesn't close #31

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Click "Authenticate with Facebook"
2. Give Facebook permission
3. The window redirects to oauthWindow.html but doesn't close

What is the expected output? What do you see instead?
oauthWindow.html should close and the token should be received. In the sample 
page, the alert containing "Got an OAuth token" should be displayed. This is 
the behavior observed with Google and Windows Live.
Instead the window does not close and the token is not received.
Sample here: 
http://gwt-oauth2.googlecode.com/svn/trunk/samples/multi/demo/Sample.html

What version of the product are you using? On what operating system?
gwt-oauth2-0.2-alpha.jar
Windows 7 64-bit
Google Chrome 19

Please provide any additional information below.
On Internet Explorer 9, the behavior is as expected (i.e. window closes, token 
is received).
Is this something that has to be done by Google Chrome or by gwt-oauth2?

Original issue reported on code.google.com by bj.nod...@gmail.com on 3 Apr 2012 at 4:35

GoogleCodeExporter commented 9 years ago 
I can confirm this works as intended on Chrome 20 for OSX and Chrome 19 for 
Linux, but I don't have a Windows machine handy to test this on Windows.

I do notice that [1] is wrong in that it calls document.body.innerHTML = "..." 
from a script in the head tag. This should be document.write() -- I'll submit a 
patch today.

But that doesn't explain why the window doesn't automatically close. I'll 
investigate further.

[1] 
http://code.google.com/p/gwt-oauth2/source/browse/trunk/src/com/google/api/gwt/o
auth2/resources/oauthWindow.html

Original comment by jasonhall@google.com on 3 Apr 2012 at 1:29

GoogleCodeExporter commented 9 years ago 
I just remembered I was on the dev release of Chrome. I tested it on a stable 
release of Google Chrome on the same machine and it works. Tested it with 
Firefox 11 on the same machine and it works as well.

I think it's safe to say this is Chrome's fault. Sorry for jumping the gun.

And while I'm here, very useful library!

Original comment by bj.nod...@gmail.com on 3 Apr 2012 at 7:09

GoogleCodeExporter commented 9 years ago 
Phew! Well in that case I'll close this as Invalid. If you happen to see this 
happening in a stable browser please ping this bug and I'll reopen it.

Thanks!

Original comment by jasonhall@google.com on 3 Apr 2012 at 7:14