search

DjangoAdminHackers / django-linkcheck

An app that will analyze and report on links in any model that you register with it. Links can be bare (urls or image and file fields) or embedded in HTML (linkcheck handles the parsing). It's fairly easy to override methods of the Linkcheck object should you need to do anything more complicated (like generate URLs from slug fields etc).
BSD 3-Clause "New" or "Revised" License
75 stars 26 forks source link

Improve object filtering #114

Closed melegiul closed 2 years ago

melegiul commented 2 years ago

Thank you for sharing this awesome app, it does a great job :tada: This PR allows to pass a function in a linklist class to apply advanced filters like Subqueries, Q and F objects, etc and solves #77 partially and can be combined with the current object filter options Thanks in advance for your feedback

claudep commented 2 years ago

Thanks Giuliano for this proposal, I think it makes sense. Would it be possible to add a test for the new functionality? I'd also move the documentation from the code to the README (under Linklist classes).

melegiul commented 2 years ago

Thank you very much for your review. I have added a test case for the filter_callable attribute and moved its documentation into the README.

claudep commented 2 years ago

Thanks a lot for your contribution!

melegiul commented 2 years ago

@claudep Thank you once again, it was a real pleasure to work with you :slightly_smiling_face: Is there anything I can do to help releasing this one? We would be very happy to use this for our next migration

claudep commented 2 years ago

Sure, I'll prepare a new release soon.

claudep commented 2 years ago

Released 1.9.1