search

DjangoAdminHackers / django-linkcheck

An app that will analyze and report on links in any model that you register with it. Links can be bare (urls or image and file fields) or embedded in HTML (linkcheck handles the parsing). It's fairly easy to override methods of the Linkcheck object should you need to do anything more complicated (like generate URLs from slug fields etc).
BSD 3-Clause "New" or "Revised" License
75 stars 26 forks source link

SSL certificates are not verified #118

Closed timobrembeck closed 1 year ago

timobrembeck commented 2 years ago

Back in the day when this library was created, certificates weren't really a thing... However, I think by now URLs with incorrect certificates should be marked as "invalid" rather than "valid", since all modern browsers refuse to open these URLs unless you accept the risk add an exception rule.

Is there a specific reason not to remove the 'verify': False, here? https://github.com/DjangoAdminHackers/django-linkcheck/blob/dfa053fbebd832e17de477dd9653472b775d0261/linkcheck/models.py#L280

claudep commented 2 years ago

Feel free to experiment and suggest a PR if you get some success!