search

DjangoAdminHackers / django-linkcheck

An app that will analyze and report on links in any model that you register with it. Links can be bare (urls or image and file fields) or embedded in HTML (linkcheck handles the parsing). It's fairly easy to override methods of the Linkcheck object should you need to do anything more complicated (like generate URLs from slug fields etc).
BSD 3-Clause "New" or "Revised" License
75 stars 26 forks source link

Releasing (sdist) does not include several folders #146

Closed claudep closed 1 year ago

claudep commented 1 year ago

When trying to release 2.0.0 (python setup.py sdist), I realized that the build was not including folders like management, migrations and that tests was empty. Probably a regression in 918d2adfb0d (ping @timoludwig).

timobrembeck commented 1 year ago

Ah ok sorry, I just tested it with python setup.py sdist bdist_wheel... does this work for you? Or maybe the "new" python -m build?

claudep commented 1 year ago

We always released source-only for django-linkcheck, so only python setup.py sdist.

timobrembeck commented 1 year ago

Ok nevermind, even without building the wheel, python setup.py sdist works for me as well with python 3.10.8 and setuptools 62.1.0.

claudep commented 1 year ago

I suspect we may be missing a packages=find_packages() line.

claudep commented 1 year ago

Indeed, with that line it works for me (I'm probably on an older Python setup than you (3.9)).

timobrembeck commented 1 year ago

Ok, interesting. Yeah sorry for the confusion, the automatic discovery did just work fine for me, so I thought I could remove the config line.

claudep commented 1 year ago

Just released!