search

DjangoAdminHackers / django-linkcheck

An app that will analyze and report on links in any model that you register with it. Links can be bare (urls or image and file fields) or embedded in HTML (linkcheck handles the parsing). It's fairly easy to override methods of the Linkcheck object should you need to do anything more complicated (like generate URLs from slug fields etc).
BSD 3-Clause "New" or "Revised" License
75 stars 26 forks source link

Compatibility with Django 2.1 #84

Closed winged closed 5 years ago

winged commented 5 years ago

Django 2.1 reorganized some of it's middleware properties, causing the checklinks management command to fail:

...
  File "/home/dv/.pyenv/versions/elearning/lib/python3.6/site-packages/linkcheck/utils.py", line 23, in load_middleware
    for method in self._request_middleware:
AttributeError: 'LinkCheckHandler' object has no attribute '_request_middleware'

I think this needs to be rewritten to not depend on private (_ prefixed) properties anymore.

fruitschen commented 5 years ago

Thanks for letting us know. It's fixed.