Use requests package instead of custom urllib requests

DjangoAdminHackers / django-linkcheck

An app that will analyze and report on links in any model that you register with it. Links can be bare (urls or image and file fields) or embedded in HTML (linkcheck handles the parsing). It's fairly easy to override methods of the Linkcheck object should you need to do anything more complicated (like generate URLs from slug fields etc).

BSD 3-Clause "New" or "Revised" License

75 stars 26 forks source link

Use requests package instead of custom urllib requests #94

Closed claudep closed 5 years ago

claudep commented 5 years ago

@fruitschen @andybak, Does this sound acceptable for you? This was driven by multiple SSL errors when running a recent server (Debian 10). You can see in the tests that there is a little change in functionality with 302 temporary redirects, which are also reported as redirects (used to be reported as 200 OK). I've seen many sites reporting a 302 when they really meant a permanent redirect. This also fixes #18.

andybak commented 5 years ago

I'd say go for it. We can fix any impact on our sites after it lands. @fruitschen - is the redirect change likely to effect us?

fruitschen commented 5 years ago

I've just merged it. @andybak The change is absolutely safe. I'll get new django 2.0 site to use the master branch. This won't affect our other sites as they are on a feature branch.

Thanks @claudep.