When copying the event we should use chosen website_slug from EventApplication

asendecka commented 7 years ago

If we try to create a new event in the city where DG workshop already happened in the past, but we want to have customized website_slug which is different from the previous Event one, we will end up having problems creating the event, because our current copy_event code is copying all data from previous event, instead of using website_slug.

What is happening right now:

There is a past event in db, i.e. Cardiff with email set to pyconuk@djangogirls.org
New EventApplication for Cardiff with custom slug: pyconuk2017 and none of organizers are the same
When we deploy the website we will copy_event from the previous one, including old email (pyconuk@)
In get_or_create_gmail we are passing event_application.website_slug as a slug to migrate_gmail_account function - in our scenario it will be pyconuk2017@ which does not exist in Gmail yet
Then in create_gmail_account we create email from Event.email and since we copied the email from old event, it's pyconuk@ which exists and was not migrated, because we used website_slug when calling migrate_gmail_account.

What we should do:

Make sure we are propagating website_slug to the Event.email from EventApplication.

Opbeat error: https://opbeat.com/django-girls/djangogirlsorg/errors/81/

ramonsaraiva commented 6 years ago

@aniav are you working (or still going to work) on this?

aniav commented 6 years ago

@ramonsaraiva thanks for nudging, I have unassigned myself from this 👍

amakarudze commented 3 years ago

@marksweb how much of this issue is affected by the work you have done in Fix multiple object error on event view [#593] #614?

marksweb commented 3 years ago

@amakarudze What I did on that issue doesn't impact on this.

I didn't change anything with the way data is collected or the new Event objects are created.

I changed the way the event detail view is handled by having it use the data that originates from website_slug instead of city. So I think that's as close as I got.

Perhaps once I'm done with the stripe donation I could take a look at this.

DjangoGirls / djangogirls

When copying the event we should use chosen website_slug from EventApplication #436