DjangoGirls / tutorial-extensions

Additional tasks for tutorial
https://tutorial-extensions.djangogirls.org
Other
163 stars 203 forks source link

Missing 'on_delete' parameter in models.ForeignKey() #106

Closed rtody closed 6 years ago

rtody commented 6 years ago

Set 'on_delete' parameter as 'models.CASCADE' in models.ForeignKey() to create field 'post'.

phalt commented 6 years ago

From Django 2.0 onwards this is a required keyword argument: https://docs.djangoproject.com/en/2.0/releases/1.9/#foreignkey-and-onetoonefield-on-delete-argument

Even if we're not pushing Django 2.x in the tutorials it's good practice 👍