DjangoGirls / tutorial-extensions

Additional tasks for tutorial
https://tutorial-extensions.djangogirls.org
Other
162 stars 202 forks source link

Syntax error in sample code. #115

Closed loridean closed 5 years ago

loridean commented 5 years ago

The apostrophe is missing before post/<pk>/remove/.

magul commented 5 years ago

What happened here?

loridean commented 5 years ago

I changed this file: https://github.com/DjangoGirls/tutorial-extensions/pull/115/files. Should I add this as another pull request? I think I added it in the wrong place at first.

mUtterberg commented 5 years ago

Nope! You're good to make fixes on your original pull request until it gets approved.

mUtterberg commented 5 years ago

Ohhhhhhhh yeah @loridean it looks like you were somehow able to revert to a prior version of that file. I'm wondering if that's an old typo that you were reading off of. I'm pretty sure you can close this PR. Your other commit on this PR was to pull PR #1 from the repo to your fork, so you've stumbled into wonderful Git voodoo here. Delete your revert-1-master branch; you don't really want to have that version.