search

DjangoGirls / tutorial-extensions

Additional tasks for tutorial
https://tutorial-extensions.djangogirls.org
Other
163 stars 203 forks source link

[Japanese translation]Fix the link to each chapter #128

Closed kaizumaki closed 5 years ago

kaizumaki commented 5 years ago

The link to each chapter in ja/README.md was incorrect, so it was fixed.

kaizumaki commented 5 years ago

Thank you for merging. However, gitbook has not been updated. Is there any problem?

das-g commented 5 years ago

Thank you for merging.

You're welcome! Thank you for the fix!

However, gitbook has not been updated.

It hasn't, indeed. Thanks for making us aware!

Is there any problem?

I don't know, but as the update should not take over an hour, I'd say yes. I'll ask around.

kaizumaki commented 5 years ago

My changes have not yet been reflected in gitbook. Could gitbook build fail?

das-g commented 5 years ago

My changes have not yet been reflected in gitbook. Could gitbook build fail?

I noticed that, too. Sorry for the inconvenience.

I don't know what's up or how to investigate it. @magul can you help?

kaizumaki commented 5 years ago

@das-g Link correction has not been reflected in gitbook yet. So I made another pull request #129 . Does this make gitbook rebuild successful?

magul commented 5 years ago

The details of these tutorial extensions on GitBook are here: https://legacy.gitbook.com/book/djangogirls/django-girls-tutorial-extensions/details

Unfortunately, I'm not able to refresh the content of the main branch there (probably need to be GitHub organization owner), so we should either merge another pull request (or somehow different change tip of master) or ask somebody with sufficient permissions to refresh that from GitBook side (can we ask you? @aniav @RachellCalhoun ).

kaizumaki commented 5 years ago

@magul @das-g Thank you for all your help.

The pull request #129 I issued was merged, so it seems that the gitbook rebuild was successful (Correcting link was working well).