search

DjangoGirls / tutorial-extensions

Additional tasks for tutorial
https://tutorial-extensions.djangogirls.org
Other
163 stars 203 forks source link

Change url to path at homework & Improve legibility #130

Open academey opened 5 years ago

academey commented 5 years ago

Hello,

I changed code like below at your ko/homework/README.md

url(r'^drafts/$', views.post_draft_list, name='post_draft_list'), to path('drafts/', views.post_draft_list, name='post_draft_list'),

And also improved legibility.

Thanks.

das-g commented 5 years ago

:+1: We should think about using the more explicit <int:pk> instead of just <pk> in the code in the English version, too.

das-g commented 5 years ago

As I don't understand corean, I've only reviewed the code change itself. Can someone from @DjangoGirls/ko-pr check whether they happen in the right context?

academey commented 4 years ago

It doesn't be reviewed for a long time I just changed orders so it will be okay for right context. Thanks. @das-g

das-g commented 4 years ago

Can someone from @DjangoGirls/ko-pr please hava a look?