search

DjangoGirls / tutorial-extensions

Additional tasks for tutorial
https://tutorial-extensions.djangogirls.org
Other
162 stars 202 forks source link

fix markup: don't treat Django template tags as GitBook tags #141

Closed das-g closed 2 years ago

das-g commented 3 years ago

Django template tags that aren't in code blocks are currently mis-interpreted as GitBook template tags, leading to wrong rendering, e.g. of https://github.com/DjangoGirls/tutorial-extensions/blob/b0c08b076eff24a001a03188c7d24d953d995df8/en/homework_create_more_models/README.md#L80-L82 at https://tutorial-extensions.djangogirls.org/en/homework_create_more_models#make-our-comments-visible:

image

This change (wrapping those tags in {% raw %} ... {% endraw %}) should hopefully fix that, but I didn't try it locally, so I couldn't check how the result looks.

Thanks to @macmurdo for pointing out this problem on Gitter.

das-g commented 2 years ago

As there hasn't been any feedback, shall we just merge this and see how the result looks?

das-g commented 2 years ago

As there hasn't been any replies and the issue continued to confuse readers of the tutorial extensions, I've merged this now, hoping it fixes the problem properly. If it makes things worse, we can always revert.