search

DjangoGirls / tutorial-extensions

Additional tasks for tutorial
https://tutorial-extensions.djangogirls.org
Other
162 stars 202 forks source link

Add Wagtail installation instructions #163

Closed amakarudze closed 1 month ago

amakarudze commented 11 months ago

Changes in this PR

amakarudze commented 8 months ago

Love it @amakarudze 😸 I think you did a great job at producing something where people can see the potential of Wagtail without it being super long.

Aside from my comments, I’d suggest to:

  • Make sure there’s no further changes needed to push this to PythonAnywhere? I’m surprised it’d all "just work" there, but maybe it’s me.
  • Update how the blog posts are fetched to only show live blog pages, and show them ordered by date.

And as quick wins that aren’t really needed but would be cool to demo:

  • Adding the Wagtail userbar. Nice little feature.
  • Perhaps making use of parent_page_types or subpage_types. This helps people understand the "child" pages quite a bit.

As a follow-up after this is merged, I’d love to know what you think of adding even more sections.

@thibaudcolas I addressed most of these points except for the quick wins that aren't really needed. They could be added later on as follow up.

thibaudcolas commented 8 months ago

🤘I’ll do my best to review this soon

thibaudcolas commented 7 months ago

Tagging @shyusu4 who has expressed an interest in reviewing this as part of her learning experience with Django & Wagtail 😌

thibaudcolas commented 6 months ago

Thank you for giving this a go @shyusu4 😌 I’m still planning to review this myself too (but have to find the time somehow…)

cc my colleague @Morsey187 who is also interested in helping with reviewing this 🚀