search

DjangoGirls / tutorial-extensions

Additional tasks for tutorial
https://tutorial-extensions.djangogirls.org
Other
163 stars 203 forks source link

put "raw" text outside of quotes & switch out <span> icons to include from static file #169

Closed moonshain closed 12 months ago

moonshain commented 12 months ago

I was doing the tutorial during a Django Girls event. I copied the code from this tutorial and it didn't work, and my coach pointed out that the "raw" text didn't belong in the code and it was probably a mistake in the tutorial.

I also changed two icons which were broken to include from static icons like in main tutorial.

das-g commented 12 months ago

Hi @moonshain

Thank you for your contribution! This approach seems to fix the problem pointed out in #156. :tada:

das-g commented 12 months ago

I've now created #170 to fix the {% raw %}/{% endraw %} problem for all occurrences.

crismotinha commented 12 months ago

I'm just adding this comment to mention how proud I am of @moonshain , joining her first DG event today and besides finishing the tutorial and the extension, opening a PR to fix it <3

das-g commented 12 months ago

Congratulations, @moonshain

Your changes are now live on https://tutorial-extensions.djangogirls.org :tada: