DjangoGirls / tutorial

This is a tutorial we are using for Django Girls workshops
http://tutorial.djangogirls.org/
Other
1.53k stars 1.86k forks source link

Japanese translation improvements from Crowdin made by: #1616

Closed magul closed 5 years ago

magul commented 5 years ago
ftnext commented 4 years ago

@magul Thank you for updating master branch!😃 I have a question: when the latest translation is deployed?

I was checking https://tutorial.djangogirls.org/ja/ for a few days, but it seems the older version (not the latest) 🤔

A workshop in Tokyo will be held in next weekend (16th Nov.), so I am glad if the latest Japanese translation is deployed by the Tokyo workshop.

magul commented 4 years ago

@ftnext, unfortunately, there's an internal problem with triggering GitBook content refresh from GitHub. We have in-depth conversation about that in #1613.

I'm in the middle of gaining access to GitBook (ping @GirlGeekUpNorth) but will also try to figure out if I'm able to trigger that deployment without using GitHub altogether.

Sorry for the inconvenience!

magul commented 4 years ago

No lucky there

magul@bohr tutorial (master=) $ git push gitbook master
Username for 'https://git.gitbook.com': magul
Password for 'https://magul@git.gitbook.com': 
Enumerating objects: 222, done.
Counting objects: 100% (167/167), done.
Delta compression using up to 4 threads
Compressing objects: 100% (85/85), done.
Writing objects: 100% (106/106), 83.77 KiB | 5.24 MiB/s, done.
Total 106 (delta 41), reused 40 (delta 11)
remote: error: failed to lock refs/heads/master
To https://git.gitbook.com/djangogirls/djangogirls-tutorial.git
 ! [remote rejected]     master -> master (failed to lock)
error: failed to push some refs to 'https://git.gitbook.com/djangogirls/djangogirls-tutorial.git'
magul commented 4 years ago

It occurs that even if CLI states update was rejected it occurs on a website. Can you confirm, that there's a most up-to-date version of Japanese tutorial?

ftnext commented 4 years ago

Can you confirm, that there's a most up-to-date version of Japanese tutorial?

I think that Japanese translation in this repo is the most up-to-date, and Japanese translation in https://tutorial.djangogirls.org/ja/ is older than this repo. It seems that there are the above 2 versions to me.

magul commented 4 years ago

@ftnext after I asked you to check I did also some checks by myself and I can confirm that this commit

https://github.com/DjangoGirls/tutorial/commit/0b5c4c084ab77dfba716a877611d0cb44f87d094 is available on GitBook right now (at least the anchors for subchapters of Installation chapter are these that were introduced in this commit).

On what basis you're claiming that there's different commit?

ftnext commented 4 years ago

@magul The issue seems to have been resolved in the last half day. I checked 0b5c4c0 is available on GitBook at the following points:

On what basis you're claiming that there's different commit?

The basis is as above.

My question is resolved now and I am relieved that the latest Japanese translation is available. It is strange that Japanese translation is updated after some days from merge. Thank you for your effort!

magul commented 4 years ago

Unfortunately, there are issues with GitHub -> Legacy Gitbook integration. I manually refreshed the content of the tutorial yesterday. More info about how I achieved that you can find in #1613 but info about that should be also in few comments above.