Put 박제권's (Jay Park's) name in Korean.

DjangoGirls / tutorial

This is a tutorial we are using for Django Girls workshops

http://tutorial.djangogirls.org/

Other

1.53k stars 1.86k forks source link

Put 박제권's (Jay Park's) name in Korean. #1692

Closed jinto closed 3 years ago

jinto commented 3 years ago

My english name is Jay Park and korean name is 박제권. You can confirm it on the linked page( https://jinto.pe.kr) after the name .

Changes in this pull request:

Name of a translater.

jinto commented 3 years ago

I've changed PR title cause it looks not polite. It was just commit message and it goes to title of the pr, sorry for my mistake. and thanks for reviewing in advance.

das-g commented 3 years ago

I've changed PR title cause it looks not polite. It was just commit message and it goes to title of the pr, sorry for my mistake.

Thank you. The original PR title would actually have been OK, but the new one is fine, too. :smile:

and thanks for reviewing in advance.

Do you still have your Crowdin account? If so, could you write me a message within crowdin to verify that you're indeed the same person?

magul commented 3 years ago

I don't believe that translation origins in Crowdin @das-g

das-g commented 3 years ago

I don't believe that translation origins in Crowdin @das-g

@magul At least there indeed is a "Jay Park" in our list of translators since over 5 years ago: Bildschirmfoto von 2020-12-01 17-31-09

magul commented 3 years ago

By default whenever somebody changes something in particular language I'm asking that language reviewers to review, but I don't believe we have a strict policy in place here.

That looks really like minor change and if your're confident that's right, I would say: go for it!

magul commented 3 years ago

two side notes here:

we can also add @jinto as a member of Koeran reviewers team here on Github
I believe I received an email, that Korean translation on Crowdin was completed, so there will be a pull request (which will be huge)