search

DjangoGirls / tutorial

This is a tutorial we are using for Django Girls workshops
http://tutorial.djangogirls.org/
Other
1.54k stars 1.86k forks source link

Simplify RunCode virtual environment installation and usage instructions #1808

Closed thibaudcolas closed 1 year ago

thibaudcolas commented 1 year ago

This essentially copies the "Virtual environment" and "Working with virtualenv: Linux and OS X" over to RunCode. There is no need to install and use virtualenv on RunCode specifically, the built-in python -m3 venv myvenv works fine there as well.

And for other environments we use source rather than . to initialise the virtual environment, so we should do the same here for consistency.

das-g commented 1 year ago

Would it make sense to simply include en/django_installation/instructions.md, like we do over there in the all-encompassing "installation" chapter: https://github.com/DjangoGirls/tutorial/blob/c3588ff3d1b48be4fb092c8dad86e3ce93feb5b9/en/installation/README.md#L61-L64 rather than duplicating the same instructions?

thibaudcolas commented 1 year ago

Good point @das-g! That makes sense to me. My only concern would be whether it’s clear enough RunCode users are meant to follow the "Linux" instructions, but since that’ll be the case elsewhere in the tutorial, seems reasonable.

Should I make that change now or wait for more feedback on this?

das-g commented 1 year ago

Would it make sense to simply include en/django_installation/instructions.md, like we do over there in the all-encompassing "installation" chapter:

https://github.com/DjangoGirls/tutorial/blob/c3588ff3d1b48be4fb092c8dad86e3ce93feb5b9/en/installation/README.md#L61-L64

rather than duplicating the same instructions?

Good point @das-g! That makes sense to me. My only concern would be whether it’s clear enough RunCode users are meant to follow the "Linux" instructions, but since that’ll be the case elsewhere in the tutorial, seems reasonable.

Should I make that change now or wait for more feedback on this?

Actually, let's do that in a separate pull request. Your changes here seem like a clear improvement and uncontroversial to me, so let me merge them right away.

Including instructions that also contain windows-specific parts in a RunCode specific page might be more controversial, so let's separate that out.