search

DjangoGirls / tutorial

This is a tutorial we are using for Django Girls workshops
http://tutorial.djangogirls.org/
Other
1.53k stars 1.86k forks source link

Issue with glyphicons in Extensions (adding to site) tutorial #1817

Open neilsquibb opened 8 months ago

neilsquibb commented 8 months ago

Issue description

Hi there.

Super new to programming and Django (this is actually my first post on GitHub, so double apologies), so I hope I am correct about the issue and that this is the right way to report it. Apologies if not, and feel free to delete.

I was doing the Extension tutorial on adding to my website, when I noticed neither the post_draft_list or post_remove icon or text was showing on my site. I did some digging around and it looks like the problem was the line

<span class="glyphicon glyphicon-remove"></span>

(and the similar line for delete) needed a class in the CSS (or something like that?) which wasn't provided (I think this was the problem anyway, not sure?).

I did a Google dive, and found that the Spanish version of the main tutorial contained a similar line including glyphicons (rather than include) for the new post button (on the Forms page: https://tutorial.djangogirls.org/es/django_forms/) on the 'Link to a page with the form' section. On the Spanish version of the tutorial it had

<span class="glyphicon glyphicon-plus"></span>

, whereas the English version (https://tutorial.djangogirls.org/en/django_forms/) had {% include './icons/file-earmark-plus.svg' %} instead. This lead me to believe that maybe the English version had been updated and the Spanish version was older?

Through deduction, I am guessing maybe the lines that contained reference to glyphicons in the Extension are aiming at a piece of code provided in an older version of the main tutorial, before it was updated? ...or I could have just made a mistake and the problem could be elsewhere? Haha.

Either way, the glyphicon lines weren't working for me, so my solution was to grab another couple of icons from the Bootstrap pack and used them instead, with {% include './icons/trash.svg' %} and {% include './icons/list' %}, whilst adding the new icons to my blog/icons folder. This did the trick nicely.

I hope this helps others if they are having the same issue!

Once again apologies if I have put this in the wrong place. I am still working out this stuff.

Thank you so much for the amazing tutorial! It has helped me loads.

das-g commented 8 months ago

Hi, @neilsquibb

Thank you for this report. Yes, this is the right place to bring this up.

I've slightly edited your post to make the HTML snippets in it visible. (GitHub uses Markdown syntax for issues and issue comments; and HTML elements in Markdown are interpreted to be part of the formatting of the post (or thrown out if not one of the few HTML tags considered "save") unless marked up as a code block or inline code snippet.)

neilsquibb commented 8 months ago

@das-g Thank you very much! I will get the hang of it eventually, haha.