search

DjangoGirlsSeoul / lightandleadership

Non-profit web project using python and django
Apache License 2.0
5 stars 6 forks source link

fixed header img sizing, responsive design #49

Closed RachellCalhoun closed 8 years ago

RachellCalhoun commented 8 years ago

fixed image sizing: replaced max-height with height:450. Added it in media queries 400px height for smaller screens. Also added push-7 to most headers so the image will be first on mobile view. Gave padding-top: 4em; to title on pages, but not on smaller screens. Also added back padding:0; for '.main' class.

RachellCalhoun commented 8 years ago

@jinpark please let me know how unreadable my html is :)

RachellCalhoun commented 8 years ago

@jinpark I tried to clean up as much as I could. i made all two words include a '-' and gave as many spaces as I could find. Let me know.

jinpark commented 8 years ago

:D/D: I didnt expect you to change the things that were not part of the PR originally

RachellCalhoun commented 8 years ago

with css classes if i change one i have to change all. So i just went for it. :)

jinpark commented 8 years ago

I mean you changed like flatpagetext when you didnt do anything to it originally.

I looked it over but didn't run it or make sure that you caught all the css classes but if you've done that then its LGTM